Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h1 hidden but make contrasty anyway #6958

Merged
merged 1 commit into from
Nov 1, 2024
Merged

h1 hidden but make contrasty anyway #6958

merged 1 commit into from
Nov 1, 2024

Conversation

lsat12357
Copy link
Contributor

Fixes

Fixes #6892

Summary

Second try: fixing h1 elt that is sr-only but still being flagged for contrast.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

*Running wave on the dashboard should not flag the navbar for contrast.
*
*

Type of change (for release notes)

notes-minor

Detailed Description

In the dashboard masthead, the visible span is compliant regarding contrast; the hidden h1 elt is not. Proposed solution is to add navbar-text class to the h1; .navbar-text is defined in views/shared/_appeearance_styles.html.erb and appears to just set color to appearance.header_text_color (.navbar-brand is set to the same color, and is used on the masthead/logo).

Changes proposed in this pull request:

  • Modifies html in views/_masthead.html

@samvera/hyrax-code-reviewers

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 41s ⏱️ + 1m 10s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit c1eb95f. ± Comparison against base commit 24e6979.

This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both. 
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f11101b2e48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2014d8d700>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1114ebaf10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2016ff1918>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4d756796-fc97-4999-8c04-bb848fdfdebb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 07185a00-800b-40f5-b8c1-e872234355b1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: fca90639-8fda-4903-8bbf-bbab4f3ac196
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 2a1cab27-0ca1-4a4c-9fcc-c6cfc81c06e1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 2ecafe4f-acca-46c7-b9a4-96590ed609cd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: dcd895e2-6013-4be6-813e-339afbf5dd85
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fad53798710>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fded8c8c080>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fad63f49b20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fdee9fc8c10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: a7b0b566-7c1e-4f38-a71c-d93122053a91
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 1947d641-3cbe-431a-b5ca-73b8f05bf184
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3779b8cf-f66f-4e9a-8869-a8b3fa296757
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: c169179d-44fd-43f5-8ffc-43fe6b258863
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 5f88fd6a-0cea-469e-ab9d-7d19e69e06ca
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: c2f059e8-2690-4dea-84a5-7cde761543b8
…

@randalldfloyd randalldfloyd merged commit 3f20242 into main Nov 1, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the issue-6892_v2 branch November 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randalldfloyd randalldfloyd randalldfloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: Works > Navigation tab links report low contrast errors
2 participants
@lsat12357 @randalldfloyd